Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R&D download before start first open #72

Closed
riderx opened this issue May 3, 2022 · 28 comments · Fixed by #242
Closed

R&D download before start first open #72

riderx opened this issue May 3, 2022 · 28 comments · Fixed by #242

Comments

@riderx
Copy link
Collaborator

riderx commented May 3, 2022

TO have the same behavior as Burger king app
IMG_4103
We could use a wording like : 'We are optimizing your app experience'

@riderx riderx changed the title R&D need first open download before start R&D download before start first open May 3, 2022
@meilechwieder
Copy link
Contributor

This is R&D for auto-update, note for manual is it's already possible.

@riderx
Copy link
Collaborator Author

riderx commented Feb 14, 2023

/bounty $100

@algora-pbc
Copy link

algora-pbc bot commented Feb 14, 2023

💎 $100 bounty created by riderx
🙋 If you start working on this, comment /attempt #72 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #72 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
ℹ️ If something is not clear ask before working on it, otherwise your chance to rework it is high
👨‍👩‍👧‍👦 Join the Discord to get help
🙏 Thank you for contributing to Cap-go/capacitor-updater!

Attempt Started (GMT+0) Solution
🟢 @ayewo Aug 9, 2023, 7:40:00 PM #242

@aazam-gh
Copy link

aazam-gh commented Apr 6, 2023

Hello, I'd like to work on this issue :)

@riderx
Copy link
Collaborator Author

riderx commented Apr 7, 2023

Hi @Alcadeus0 that awesome ! please feel free to ask here any missing info

@aazam-gh
Copy link

aazam-gh commented Apr 8, 2023

@riderx How do I reproduce this issue?

@riderx
Copy link
Collaborator Author

riderx commented Apr 8, 2023

@Alcadeus0 you can use the demo app:
https://github.com/Cap-go/demo-app

Acceptance criterial:

  • updated should be download and apply at first launch
  • a loader is visible while the download happen
  • works both in ios and android
  • no code duplication

@aazam-gh
Copy link

aazam-gh commented Apr 8, 2023

@riderx running npx cap verify gives me
image
why isn't the pod being found?

@riderx
Copy link
Collaborator Author

riderx commented Apr 9, 2023

this command run from the CI and in local, did you run the command in the root folder?

@aazam-gh
Copy link

aazam-gh commented Apr 9, 2023

yes I'm running in the root folder, maybe that's why

@riderx
Copy link
Collaborator Author

riderx commented Apr 10, 2023

mmm ok sorry, you have to have the package manager cocoa pods and use a mac.
This task is pretty hard, good knowledge in ios/android is recommended.
plus you have to understand capacitor env

@aazam-gh
Copy link

@riderx i see that's understandable. I use Ubuntu so it won't be possible even if i decide to use a vm with mac OS. You can un-assign me from the issue

@riderx
Copy link
Collaborator Author

riderx commented Apr 10, 2023

I can grant you of half the price if you find a solution in android

@aazam-gh
Copy link

Sure, I'll give it a shot

@ayewo
Copy link
Contributor

ayewo commented Aug 9, 2023

Hi @meilechwieder,

Regarding your earlier comment:

This is R&D for auto-update, note for manual is it's already possible.

If you have a moment, mind sharing more details how you currently do it manually?

@ayewo
Copy link
Contributor

ayewo commented Aug 9, 2023

Here goes nothing while I /attempt #72 .

Options

@riderx
Copy link
Collaborator Author

riderx commented Aug 17, 2023

Hey @ayewo I made half of this working, it's done in IOS, I still have some issue in Android.
Have you something on your side ?
Maybe we can join forces

@ayewo
Copy link
Contributor

ayewo commented Aug 17, 2023

Hi @riderx

Maybe we can join forces

You've already done 50% do I really have a choice 😀?

Since you've coded the iOS implementation, perhaps you could share it so I can translate it for Android.

@riderx
Copy link
Collaborator Author

riderx commented Aug 17, 2023

I'm sorry, I really needed it, and a shower showed me the way ^^.
I just finished the Android part as well 5 min ago.

So the bounty in this state is not available anymore.
I would more now try to battle test it, and be sure this work 100% of the time.
Can you help on that ?
I can do 100 bounty for this

@ayewo
Copy link
Contributor

ayewo commented Aug 17, 2023

Haha @ shower thoughts 😁

Sure. I updated the capacitor-related dependencies for the demo-app from v4.x.x to v5.x. and will share that later.

Is that what you used for initial testing.

@riderx
Copy link
Collaborator Author

riderx commented Aug 17, 2023

i use prod app but you can use this one too

@algora-pbc
Copy link

algora-pbc bot commented Aug 18, 2023

💡 @ayewo submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

@ayewo
Copy link
Contributor

ayewo commented Aug 18, 2023

Hey Martin @riderx,

Testing on iOS and Android ended up taking quite a bit of time ... I think some refactoring and/or some unit tests will be useful—especially for the partial download feature—as I ran into some scenarios where some bundles were failing to delete.

Miscellaneous Issues

  • On Android, I did get the occasional A resource failed to call release so there's a resource leak somewhere.
  • The CLI seems to output an invalid URL at the end of a bundle upload. Towards the end, it will offer the following 404 URL https://web.capgo.app/app/p//logs in its output (or maybe I don't have authorization to see it?):
  Check logs in https://web.capgo.app/app/p//logs to see if update works.

  Welcome onboard ✈️!

  Your Capgo update system is setup

  Next time use `npx @capgo/cli@latest bundle upload` to only upload your bundle

  Bye 👋

@riderx
Copy link
Collaborator Author

riderx commented Aug 18, 2023

I think you are right i never tested end to end local env so that could be broken, if you need time to fix it i can do bounty for that

@ayewo
Copy link
Contributor

ayewo commented Aug 19, 2023

The demo app worked on both iOS and Android in my testing. Had to fix a minor logic bug in the demo app (the Splashscreen was shown too quickly, an if block never got called) and fixed a minor bug in the iOS plugin.

For the miscellaneous issues, I can open a separate ticket for them later as they’ll require time for me to investigate and fix them.

Right now, I’m trying to complete the work I started on #119 so please accept the PRs I opened for this issue:

Thanks!

@algora-pbc
Copy link

algora-pbc bot commented Aug 22, 2023

🎉🎈 @ayewo has been awarded $100! 🎈🎊

@FernetB
Copy link

FernetB commented Feb 23, 2024

Hi!, i have a question

Where i can see how to make a loading page with auto update: true and direct: true?

@riderx
Copy link
Collaborator Author

riderx commented Feb 24, 2024

You can find it here:
https://capgo.app/docs/plugin/force-update/#direct-update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants