support Component #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cap32
reviewed
Nov 14, 2017
src/index.js
Outdated
| const { usingComponents = {} } = | ||
| await readJson(`${instance}.json`).catch(::console.error); | ||
| const componentBase = parse(instance).dir; | ||
| for (const relativeComponent of Object.values(usingComponents)) { |
There was a problem hiding this comment.
为了兼容 Node.js 低于 v7 版本，需要用 lodash.values() 代替 Object.values()
|
Nice！ 只是小问题，为了兼容低于 |
|
已改用 |
|
谢谢 @NKCoding |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持编译被 page 引用的 component