feat: basic dragResize component and storybook examples #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import React, { createRef, useEffect, useState } from 'react'; | ||
| import style from './dragResize.module.css'; | ||
|
|
||
| export type DragResizeProps = { |
There was a problem hiding this comment.
can you move on top the mandatory properties, please?
src/dragResize/DragResize.tsx
Outdated
| firstPaneMinSize?: number; | ||
| }; | ||
|
|
||
| const FirstPane: React.FunctionComponent<{ |
There was a problem hiding this comment.
I suppose that is the way:
const FirstPane:= ({
children,
width,
height,
setWidth,
setHeight,
orientation,
className,
}: FirstPaneProps) => {and you define the FirstPaneProps ?
src/dragResize/DragResize.tsx
Outdated
| const isVertical = orientation === 'vertical'; | ||
|
|
||
| useEffect(() => { | ||
| if (firstRef.current) { |
There was a problem hiding this comment.
why not:
if (firstRef.current && isVertical && !width) {
setWidth(firstRef.current.clientWidth);
} else if(!height) {
setHeight(firstRef.current.clientHeight);
} 
|
Height to be applied as a percentage as opposed to in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component and Storybook examples of horizontal and vertical dragResize component
#169