Insert designing #516
Merged
Insert designing #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR Kavhita, overall looks good! 👏 👏 I'll be just leaving some notes if you don't mind :) |
cg-mmirca
reviewed
Jun 29, 2023
cg-mmirca
requested changes
Jul 12, 2023
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## release/0.8 #516 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 67 67
Lines 1240 1240
Branches 458 458
=============================================
Hits 1240 1240 ☔ View full report in Codecov by Sentry. |
mmirca
force-pushed
the
feature/ds-insert-text
branch
from
5745ecd
to
7decf41
Compare
daniele-zurico
approved these changes
Jul 18, 2023
cg-mmirca
approved these changes
Jul 18, 2023
daniele-zurico
added a commit
that referenced
this pull request
Sep 15, 2023
* [Design-System-FormSelect] Build the design system for the FormSelect component (#421) * feat: add design system * feat: fix conflicts * feat: final push * feat: final push * feat: revert some bad merge * feat: revert some bad merge * feat: add chromatic build * Feature/sb 0.7 (#474) * feat: migrating sb to 7 * feat: add the Button stories * feat: add charactercount to v7 * feat: add checkboxgroup to v7 * feat: add radiogroup to v7 * feat: add radiogroup to v7 * feat: add toggle to v7 * feat: add tooltip to v7 * feat: add range to v7 * feat: add multiUpload to v7 * feat: add select to v7 * feat: add multiselect to v7 * feat: add input to v7 * feat: add inputMask to v7 * feat: autocomplete to v7 * feat: autocomplete to v7 * feat: tabs to v7 * feat: details to v7 * feat: table to v7 * feat: fix live edit version (#476) * feat: cleanup example deps (#478) * Bug/autocomplete keydown scroll (#472) * BugFix: Autocomplete doesn't auto scroll for filtered list on keydown * Fixed Linting and test issues * Added Test and Refactered * feat: fix the documentation * feat: fix the documentation --------- Co-authored-by: Zurico.Daniele_DEFRA <daniele.zurico@gmail.com> * feat: remove controls (#481) * Feature/heading (#482) * Implement <Heading> component * lint fixes * give better description to what Header component does in docs * refactor Heading Component to make less verbose * refactor ClassBased and create Headings for all levels * add specific testing * lint fix * make className and id optional * Update src/heading/Heading.tsx Co-authored-by: Isaac Babalola <Ibabalola@users.noreply.github.com> * Update src/heading/__test__/Heading.test.tsx * Update src/heading/__test__/Heading.test.tsx * fix: resolving heading issues * fix: resolving heading issues * update docs --------- Co-authored-by: aismaelcap <aismael@aismaels-MacBook-Pro.local> Co-authored-by: Daniele Zurico <daniele.zurico@gmail.com> Co-authored-by: Isaac Babalola <Ibabalola@users.noreply.github.com> Co-authored-by: Isaac Babalola <info@isaacbabalola.co.uk> * fix: heading component (#489) * Feature/label (#483) * Button demo test * Created Label component * added return statement * dcx-label embeded class updated * removed return statement * resolved all issues and added classbased stories * dcx-label, value mandatory field, govuk-label * added Typography for stories * Add new properties to the button component developer specified class name and a variant (#490) * Add new properties to the button component developer specified class name and a variant * resolve PR comment to cover developer specifiedclass name * Update src/button/Button.tsx Co-authored-by: Isaac Babalola <Ibabalola@users.noreply.github.com> * feat: make the code more dynamic * feat: add in the doc * feat: add in the doc * feat: add in the doc * resolve PR comment to simplify code and get it more readable --------- Co-authored-by: Berhane Yohannes <berhane.yohannes@capgemini.com> Co-authored-by: Daniele Zurico <daniele.zurico@gmail.com> Co-authored-by: Isaac Babalola <Ibabalola@users.noreply.github.com> * feat: remove duplicated story (#493) * Feature/link (#494) * created link component * Link component demo and stories * added new test case, added govuk-link css * added styles for link component * InsertTextComponent (#491) * InsertTextComponent * resolved pr comments * InsertTextComponent * resolved pr comments * resolved changes * feat: improve documentation * feat: improve documentation --------- Co-authored-by: kavithakurella-dev <132873865+kavithakurella-dev@users.noreply.github.com> Co-authored-by: Zurico.Daniele_DEFRA <daniele.zurico@gmail.com> * Feature/autocomplete update value (#496) * fix: {{ Autocomplete component - changing defaultValue prop has no affect }} * test: {{When defaultValue prop is changed, Autocomplete component updates. }} * test: {{Test updated with dom manipulation rather than re-rendering and fix has been commented out to intentionally see test failing}} * test: {{Now, uncommented the fix and verify that the test passes as intended}} * Feature/paragraph (#479) * feature/paragraph * paragraph doc and test * Update src/paragraph/Paragraph.tsx Co-authored-by: Daniele Zurico <daniele.zurico@gmail.com> * adressing pr comments. * update stories. * added more attribute. * new comments has been resolved. * paragraph live has been also updated. * files has been updated. * feat: update test for Heading * feat: update story --------- Co-authored-by: Daniele Zurico <daniele.zurico@gmail.com> * KeyboardInput Component (#504) * KeyboardInput Component * KeyboardInput * KeyboardInput * Commponent * KeyboardInput * feat: minor fix --------- Co-authored-by: kavithakurella-dev <132873865+kavithakurella-dev@users.noreply.github.com> Co-authored-by: Zurico.Daniele_DEFRA <daniele.zurico@gmail.com> * feature/blockquote (#505) * feature/blockquote * some more changes. * block quote component update. * update previewjs * intendation. * test file name test * test file * tsx * blockquote file * delete quote file * blockquote file. * delete blockquotelive * blockquoutelive * some comments has been fixed. * footer type has been made optional. * props type has been changed. * test has been updated. * documentation fix and styled class based component * deleted unstyled class based story. * styled with classname * feat: upgrade storybook and minor refactor --------- Co-authored-by: Zurico.Daniele_DEFRA <daniele.zurico@gmail.com> * create a list component (#495) * folder structure and test case scenarios added * files named changed from listitem to list * Added required test cases * added comments and updated code * code improvements * List compo mandatory for ListItem compo * code modifications * code improvements * feat: add value * feat: add value * feat: refactor list * feat: refactor list * added 3 new props * feat: fix props * feat: fix props * new test cases and stories added * added styling * code improvements * MarkerTypes seperated * added new style file for classbased.stories --------- Co-authored-by: Zurico.Daniele_DEFRA <daniele.zurico@gmail.com> * expose and document the hook useHydrated (#510) * expose the function clientOnly for client side rendering * document the function clientOnly for client side rendering * document useHydrated and create its own unit test file --------- Co-authored-by: Berhane Yohannes <berhane.yohannes@capgemini.com> * Highlight Component (#509) * feat: {{ Highlight component }} * test: {{ Adding unit tests for Highlight component }} * feat: {{ Tweaking Highlight component and test }} * feat: {{ Fixing storybook preview }} * feat: {{ Adding Demo, Storybook docs and live demo for Highlight Component }} * feat: {{ Tweaking Demo, Storybook docs and live demo }} * feat: {{ Tidy up }} * feat: {{ Modify to allow <Highlight>highlighted text </Highlight> usage without text prop }} * feat: {{ Removing commented out }} * feat: {{ Replacing HTMLQuoteElement with HTMLElement }} * feat: {{ Simplfying rendered function in class based stories and adding custom styling }} * feature/abbreviate (#512) * PreformattedText component (#511) * PreformattedText component * PreformattedText * PreformattedText comments * Resolved * setting.json resolved --------- Co-authored-by: kavithakurella-dev <132873865+kavithakurella-dev@users.noreply.github.com> * Breadcrumbs components (#508) * Breadcrumbs components * Added stories * Added official govuk style file * selected item * added separator functionality * improved separator * final * storybook order * feature/code (#507) * feature/code * text replaced with value. * code componets has been resolved as suggested. * Fix: CharacterCount component not resetting red error text after valid input (#471) * fix: charactercount component not resetting red error text after valid input * fix: the character count component error message returns to default after the text area is cleared --------- Co-authored-by: Nikki Algar <nikki.algar@digital.homeoffice.gov.uk> Co-authored-by: Berhane Yohannes <berhane.yohannes@capgemini.com> * Label Design System (#515) * Label Design System * Playground * comments resolved and added accessible page * Proper css for Label added and Dark theme added * feat: improve label color contrast on accesible and dark theme --------- Co-authored-by: mmirca <marius.mirca@capgemini.com> * Feature/ds-paragraph (#514) * feature/ds-paragraph --------- Co-authored-by: mmirca <marius.mirca@capgemini.com> * feat: Tabs are now non-js compliant (#506) * feat: Tabs are now non-js compliant --------- Co-authored-by: Zurico.Daniele_DEFRA <daniele.zurico@gmail.com> * Insert designing (#516) * Design InsertText --------- Co-authored-by: kavithakurella-dev <132873865+kavithakurella-dev@users.noreply.github.com> Co-authored-by: mmirca <marius.mirca@capgemini.com> * feat: add button tokens (#520) * feat: add list item design system styles (#519) * feat: add heading design system styles (#521) * Feature/bot upgrade libs (#525) * feat: upgrade libraries * Feature/release notes (#527) * feat: update release notes * feat: update release notes * feat: upgrade to 0.8.0 --------- Co-authored-by: peter-uzor-capgem <120393762+peter-uzor-capgem@users.noreply.github.com> Co-authored-by: aismaelcap <121889403+aismaelcap@users.noreply.github.com> Co-authored-by: aismaelcap <aismael@aismaels-MacBook-Pro.local> Co-authored-by: Isaac Babalola <Ibabalola@users.noreply.github.com> Co-authored-by: Isaac Babalola <info@isaacbabalola.co.uk> Co-authored-by: JadhavJeet <100856152+JadhavJeet@users.noreply.github.com> Co-authored-by: Berhane Yohannes <42332389+byohannes@users.noreply.github.com> Co-authored-by: Berhane Yohannes <berhane.yohannes@capgemini.com> Co-authored-by: KavithaKurella <122851121+KavithaKurella@users.noreply.github.com> Co-authored-by: kavithakurella-dev <132873865+kavithakurella-dev@users.noreply.github.com> Co-authored-by: Ahmet <45479018+Ahmet-K@users.noreply.github.com> Co-authored-by: Yunus FIRAT <yunusfirat44@gmail.com> Co-authored-by: Nikki Algar <nikki.algar@capgemini.com> Co-authored-by: Nikki Algar <nikki.algar@digital.homeoffice.gov.uk> Co-authored-by: mmirca <marius.mirca@capgemini.com> Co-authored-by: Sri Viswanathan <sri@protodiv.com> Co-authored-by: jgonza16 <93665374+jgonza16@users.noreply.github.com> Co-authored-by: SOUNDAR-A <138137507+SOUNDAR-A@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.