Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Lookup Binding with a test to cover it #43

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

markcunninghamuk
Copy link
Member

Purpose

Adds the ability to click a related lookup field on the form.

Approach

New behaviour that is missing from easyrepro. Uses existing elements and extends it.

TODOs

  • Automated test coverage for new code
  • Documentation updated (if required)
  • Build and tests successful

@ewingjm
Copy link
Member

ewingjm commented Oct 28, 2020

Thanks @markcunninghamuk.

Happy for you to Squash and merge as an admin once the required checks are in. Just make sure you override the merge message e.g. 'feat: open a lookup record (#43)'. You'll also need a +semver: minor in the commit body to increment the minor version.

@ewingjm ewingjm closed this Oct 28, 2020
@ewingjm ewingjm reopened this Oct 28, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@markcunninghamuk markcunninghamuk merged commit 94a0148 into master Oct 28, 2020
@markcunninghamuk markcunninghamuk deleted the mc/addLookupClickFromEntity branch October 28, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants