Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grid column sorting #47

Merged
merged 1 commit into from
Nov 19, 2020
Merged

fix: grid column sorting #47

merged 1 commit into from
Nov 19, 2020

Conversation

ewingjm
Copy link
Member

@ewingjm ewingjm commented Nov 18, 2020

Purpose

Grid column sorting is fixed in a later version of EasyRepro than we were dependent on. Unfortunately, it was a breaking change - so users wouldn't have been able to fix this by updating the EasyRepro package dependency alone.

Approach

Updates to the latest version of EasyRepro and updates the step binding to capture the additional parameter that is required.

TODOs

  • Automated test coverage for new code
  • Documentation updated (if required)
  • Build and tests successful

@ewingjm ewingjm added the bug Something isn't working label Nov 18, 2020
@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ewingjm ewingjm merged commit d6424e4 into master Nov 19, 2020
@ewingjm ewingjm deleted the bugfix/grid-column-sorting branch November 19, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant