fix: subgrid binding asserting against JS values #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may need to bypass code coverage on this one, I couldn't find a sub-grid that wasn't using card views or a custom control to test against in the out-of-the-box apps. |
|
Kudos, SonarCloud Quality Gate passed! |
Have you been able to test this at least on a project? |
Yep, this change fixed a number of failing tests - tested by adding a local reference. |
tdashworth
approved these changes
Dec 8, 2020
ewingjm
deleted the
bugfix/then-the-subgrid-contains-a-record-with-x-in-the-y-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #10.
Then the subgrid contains a record with '(.*)' in the '(.*)' fieldwas asserting against values retrieved from JavaScript rather than from the UI. This resulted in dates being compared with something likeTue Mar 24 2015 17:00:00 GMT-0700 (Pacific Daylight Time).Approach
Now compares against values as shown in the UI.
TODOs