tech-debt: sonar-cloud changes for formatting issues and "MapAliasses… #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…", "ReadCsvValue", "CreateCsvLine" functions.
This was
linked to
issues
Jan 5, 2023
tdashworth
previously approved these changes
Jan 5, 2023
|
@shraines there are 4 "bugs" identified by SonarCloud. Could you quickly add some null checks and throw a |
|
Kudos, SonarCloud Quality Gate passed! |
tdashworth
approved these changes
Jan 6, 2023
markcunninghamuk
pushed a commit
that referenced
this pull request
Sep 25, 2023
* tech-debt: sonar-cloud changes for formatting issues and "MapAliasses", "ReadCsvValue", "CreateCsvLine" functions. * Tech-deck: Sonar cloud fixes to remove nulls from execution paths * Tech-Debt: changed System exception to custom * Tech-Deck: added unit tests to cover changed lines
markcunninghamuk
pushed a commit
that referenced
this pull request
Sep 25, 2023
* tech-debt: sonar-cloud changes for formatting issues and "MapAliasses", "ReadCsvValue", "CreateCsvLine" functions. * Tech-deck: Sonar cloud fixes to remove nulls from execution paths * Tech-Debt: changed System exception to custom * Tech-Deck: added unit tests to cover changed lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…", "ReadCsvValue", "CreateCsvLine" functions.