Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for empty reference strings #122

Merged
merged 3 commits into from
Jun 22, 2018
Merged

Added test for empty reference strings #122

merged 3 commits into from
Jun 22, 2018

Conversation

sonofmun
Copy link
Contributor

Fixes #119

I still need to write unit tests for this test
Plus unit tests, changed to CHANGED.txt, and bumped version in setup.py
@sonofmun
Copy link
Contributor Author

My bad. Didn't run all unit tests locally before pushing. Will check this out and fix it locally.

Also deleted an old .rng kept just in case
@coveralls
Copy link

coveralls commented Jun 22, 2018

Coverage Status

Coverage increased (+0.05%) to 94.839% when pulling 7f9972c on empty_refs into 4676bb8 on master.

Copy link
Member

@PonteIneptique PonteIneptique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !

@PonteIneptique PonteIneptique merged commit 08d22e7 into master Jun 22, 2018
@PonteIneptique PonteIneptique deleted the empty_refs branch June 26, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants