Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr review #196

Merged
merged 12 commits into from Oct 15, 2019
Merged

Pr review #196

merged 12 commits into from Oct 15, 2019

Conversation

PonteIneptique
Copy link
Member

Response to all review comments ;)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 94.116% when pulling 6813cbe on pr-review into 7165528 on dev.

Copy link
Contributor

@sonofmun sonofmun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo change in a docstring. Otherwise this looks good.

MyCapytain/errors.py Outdated Show resolved Hide resolved
@PonteIneptique PonteIneptique merged commit 3ff0f27 into dev Oct 15, 2019
@sonofmun sonofmun deleted the pr-review branch December 16, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants