Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 60 #61

Merged
merged 7 commits into from Jan 16, 2018
Merged

Issue 60 #61

merged 7 commits into from Jan 16, 2018

Conversation

PonteIneptique
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6181fd5 on issue-60 into ** on master**.

@PonteIneptique
Copy link
Member Author

Can you review @sonofmun ? I'll squash then

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4958408 on issue-60 into ** on master**.

sonofmun
sonofmun approved these changes Jan 16, 2018
View reviewed changes
Copy link
Contributor

@sonofmun sonofmun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't give detailed feedback about everything, but what I do understand looks good to me.

@PonteIneptique
Copy link
Member Author

Thanks :)

@PonteIneptique PonteIneptique merged commit 34eb3fb into master Jan 16, 2018
@PonteIneptique PonteIneptique deleted the issue-60 branch February 6, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonofmun sonofmun sonofmun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PonteIneptique @coveralls @sonofmun