Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added framebuffer class and documentation #3

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Added framebuffer class and documentation #3

merged 5 commits into from
Jul 28, 2022

Conversation

Raelr
Copy link
Contributor

@Raelr Raelr commented Jun 21, 2022

Added the Framebuffer class. This class abstracts the Vulkan Framebuffer object and makes it a little more managable/readable when using it.

@Raelr Raelr requested a review from jonjondev June 21, 2022 13:47
@Raelr Raelr self-assigned this Jun 21, 2022
jonjondev
jonjondev approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@jonjondev jonjondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and reads better. See comments. Also good idea on starting to move include guards away from #pragma once; added a commit to do the rest too.

engine/render/renderer/swapchain/Swapchain.h Show resolved Hide resolved
engine/render/renderer/pass/RenderPass.cpp Outdated Show resolved Hide resolved
engine/render/renderer/framebuffer/Framebuffer.h Show resolved Hide resolved
@Raelr Raelr changed the title Added framebuffer class and documentation [Feature] Added framebuffer class and documentation Jul 19, 2022
@jonjondev jonjondev changed the title [Feature] Added framebuffer class and documentation Added framebuffer class and documentation Jul 21, 2022
jonjondev
jonjondev approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@jonjondev jonjondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry looks like I forgot to resubmit a review. One comment from last time was not addressed and please remove your usage of [feature] and [refactor] naming on the PRs. The verb usage in the title implies this and we can decide on a set of labels in the future if we really need to sort PRs down the line.

engine/render/renderer/pass/RenderPass.cpp Outdated Show resolved Hide resolved
jonjondev
jonjondev approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@jonjondev jonjondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One last piece of feedback but good to merge now once you do that.

engine/render/renderer/pass/RenderPass.cpp Show resolved Hide resolved
engine/render/renderer/swapchain/Swapchain.cpp Outdated Show resolved Hide resolved
engine/render/renderer/swapchain/Swapchain.cpp Show resolved Hide resolved
jonjondev
jonjondev approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@jonjondev jonjondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry one last comment

engine/render/renderer/Core.h Outdated Show resolved Hide resolved
@Raelr Raelr force-pushed the feature/framebuffer branch 4 times, most recently from 39188e3 to 4c7217d Compare July 28, 2022 13:13
@Raelr Raelr merged commit b92bfac into main Jul 28, 2022
@Raelr Raelr deleted the feature/framebuffer branch July 28, 2022 22:22
@jonjondev jonjondev added documentation Improvements or additions to documentation render Relating to the engine's renderer labels Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjondev jonjondev jonjondev approved these changes

Assignees

@Raelr Raelr

Labels
documentation Improvements or additions to documentation render Relating to the engine's renderer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Raelr @jonjondev