Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implemented math classes to enable raycasting and improve precision #47

Merged
merged 8 commits into from
Jul 23, 2023
Merged

Re-implemented math classes to enable raycasting and improve precision #47

merged 8 commits into from
Jul 23, 2023

Conversation

Raelr
Copy link
Contributor

@Raelr Raelr commented Jul 9, 2023 •
edited
Loading

Description

The PR has been...

  • provided a reasonable name that is not just the branch name (e.g "Added Vulkan render delegate")
  • linked to its related issue
  • assigned a reviewer from the team
  • labelled appropriately

The code has been...

  • made mergable and free of conflicts in relation to master (according to GitHub)
  • tested in a packaged state using the package targets
  • pulled to the reviewer's machine and reasonably tested

This was linked to issues Jul 9, 2023
Make the Vec2, Vec3 and Vec4 classes constexpr-able #26
Closed
Implement Raycasting functions #44
Closed
@Raelr Raelr force-pushed the feature/math-overhaul branch 22 times, most recently from b84633b to c479165 Compare July 18, 2023 00:32
@Raelr Raelr force-pushed the feature/math-overhaul branch 2 times, most recently from fd7c98d to fdcbeb3 Compare July 18, 2023 01:08
@Raelr Raelr marked this pull request as ready for review July 18, 2023 01:35
@Raelr Raelr requested a review from jonjondev July 18, 2023 01:36
@Raelr Raelr added enhancement New feature or request render Relating to the engine's renderer utils Relating to the engine's utils labels Jul 18, 2023
jonjondev
jonjondev approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@jonjondev jonjondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mostly docs to re-add some small changes required otherwise.

engine/utils/Logging.h Outdated Show resolved Hide resolved
engine/render/renderer/platform/vulkan/IndexBuffer.h Outdated Show resolved Hide resolved
engine/render/renderer/renderer/Renderer2D.cpp Outdated Show resolved Hide resolved
engine/utils/math/vec/Equality.h Show resolved Hide resolved
engine/utils/math/vec/Vec2.h Outdated Show resolved Hide resolved
engine/utils/math/vec/Vec4.h Show resolved Hide resolved
tests/utils/test_Mat2.cpp Show resolved Hide resolved
tests/utils/test_Projection.cpp Outdated Show resolved Hide resolved
tests/utils/test_Vec2.cpp Show resolved Hide resolved
@Raelr Raelr merged commit 0af85cd into main Jul 23, 2023
4 of 5 checks passed
@Raelr Raelr deleted the feature/math-overhaul branch July 23, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjondev jonjondev jonjondev approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request render Relating to the engine's renderer utils Relating to the engine's utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Raycasting functions Make the Vec2, Vec3 and Vec4 classes constexpr-able
2 participants
@Raelr @jonjondev