Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created a TextureAtlas class for managing textures packed into a single space #65

Merged
merged 3 commits into from
Nov 25, 2023
Merged

Created a TextureAtlas class for managing textures packed into a single space #65

merged 3 commits into from
Nov 25, 2023

Conversation

Raelr
Copy link
Contributor

@Raelr Raelr commented Nov 15, 2023 •
edited by jonjondev
Loading

Description

Added a fixed size texture atlas class. The class is not complete, however the current feature-base is enough to continue working on the tilemap feature.

The PR has been...

  • provided a reasonable name that is not just the branch name (e.g "Added Vulkan render delegate")
  • linked to its related issue
  • assigned a reviewer from the team
  • labelled appropriately

The code has been...

  • made mergable and free of conflicts in relation to master (according to GitHub)
  • tested in a packaged state using the package targets
  • pulled to the reviewer's machine and reasonably tested

@Raelr Raelr added enhancement New feature or request render Relating to the engine's renderer labels Nov 15, 2023
@Raelr Raelr self-assigned this Nov 15, 2023
@Raelr Raelr linked an issue Nov 15, 2023 that may be closed by this pull request
Add a TextureAtlas class #61
Closed
@Raelr Raelr requested a review from jonjondev November 20, 2023 20:07
@Raelr Raelr marked this pull request as ready for review November 20, 2023 20:07
jonjondev
jonjondev approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@jonjondev jonjondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Looking forward to the texture updates I got a preview of!

Running on my local here:
Screenshot 2023-11-24 at 12 06 29 pm

engine/render/renderer/renderer/BillboardRenderer.cpp Show resolved Hide resolved
examples/tilemap/src/main.cpp Show resolved Hide resolved
engine/render/renderer/platform/vulkan/TextureAtlas.cpp Show resolved Hide resolved
engine/render/renderer/platform/vulkan/TextureAtlas.cpp Show resolved Hide resolved
@Raelr Raelr merged commit ad7b72d into main Nov 25, 2023
5 checks passed
@Raelr Raelr deleted the feat/texture-atlas branch November 25, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjondev jonjondev jonjondev approved these changes

Assignees

@Raelr Raelr

Labels
enhancement New feature or request render Relating to the engine's renderer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a TextureAtlas class
2 participants
@Raelr @jonjondev