Injector, Popup and Manifest internationalisation + Popup style #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manu1400
reviewed
Jul 19, 2018
| }, | ||
| "settingYoutubeOverlay": { | ||
| "message": "Youtube Overlay", | ||
| "description":"Setting to activate the video overlay on Youtube." |
There was a problem hiding this comment.
Youtube -> YouTube (like on https://en.wikipedia.org/wiki/YouTube)
Manu1400
reviewed
Jul 19, 2018
| "description":"The description of the application, displayed in the web store." | ||
| }, | ||
| "settingYoutubeOverlay": { | ||
| "message": "Intégration dans Youtube", |
There was a problem hiding this comment.
Youtube -> YouTube (like on https://fr.wikipedia.org/wiki/Youtube)
Manu1400
approved these changes
Jul 19, 2018
| }, | ||
| "openOnCF": { | ||
| "message": "Open this video on CaptainFact.io", | ||
| "description":"Status label when button is disactivated." |
There was a problem hiding this comment.
disabled ? off ? deactivated ?
Pull Request Test Coverage Report for Build 56
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injector
Now available in French
Popup
Old popup
New popup