Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #117 : Fonts and other assets are not included in build with new webpack build #118

Merged
merged 5 commits into from
May 15, 2018
Merged

Fixed #117 : Fonts and other assets are not included in build with new webpack build #118

merged 5 commits into from
May 15, 2018

Conversation

NGambini
Copy link
Contributor

No description provided.

@NGambini NGambini requested a review from Betree May 15, 2018 11:35
@Betree Betree changed the base branch from master to staging May 15, 2018 12:04
Betree
Betree approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. We'll need a way to version fonts but that's another issue.

@Betree Betree merged commit b51e734 into staging May 15, 2018
@Betree Betree mentioned this pull request May 15, 2018
Closed
@Betree Betree deleted the fix/webpackCopyPlugin branch May 16, 2018 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Betree Betree Betree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NGambini @Betree @fbn-ngambini