Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video form: Accept url as URL param (/videos/add?url=xxx) #155

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

Betree
Copy link
Member

@Betree Betree commented Jul 18, 2018

What

Old URL scheme

/videos/add/https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DSP5MYeBdxiE

New URL scheme

/videos/add?url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DSP5MYeBdxiE

Why

  • More standard
  • Was encountering bugs with this on chrome on localhost
  • Prettier
  • It will be easier to accept different params in the future. For example, we could accept a provider and an id, like: /videos/add?provider=youtube&id=3DSP5MYeBdxiE

How

Component now support both schemes but the old one should be removed once all extensions have been migrated to >= 0.8.4 (see #156).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants