✨ Ignore le chiffre 100 pour magic_numbers #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
car le chiffre 100 est un nombre très générique, souvent utilisé pour faire des calculs de pourcentage. Il n'y a pas un gros enjeu d'extraire ce chiffre dans une constante nommé Cela permettra de simplifier son implémentation auprès de certains projets. Exemple de CI qui échoue à cause de ce nombre : https://git.captive.fr/captive/hedwige/-/jobs/484956
cprodhomme
force-pushed
the
ignore-chiffre-100
branch
from
a4cad12
to
12a3de4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
car le chiffre 100 est un nombre très générique, souvent utilisé pour faire des calculs de pourcentage. Il n'y a pas un gros enjeu d'extraire ce chiffre dans une constante nommé
Cela permettra de simplifier son implémentation auprès de certains projets. Exemple de CI qui échoue à cause de ce nombre :