Change priority to use zpriority and change default priority to +inf #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJRenold
force-pushed
the
aj-update-priority
branch
from
9abe187
to
b51dfbf
Compare
yorinasub17
reviewed
Feb 13, 2017
| @@ -3,7 +3,7 @@ | |||
| setup( | |||
There was a problem hiding this comment.
You need to update the download_url too
yorinasub17
reviewed
Feb 13, 2017
README.md
Outdated
|
|
||
| ## Using with celery tasks - zpriority | ||
|
|
||
| task.apply_async(zpriority=10) |
There was a problem hiding this comment.
That's pretty crazy that you can straight pass through celery a new option like this.
yorinasub17
approved these changes
Feb 13, 2017
|
@yorinasub17 I can see that. But I think using "priority" is worse since the ranges of priority differ and the meaning of priorities differ (in normal priority, larger means high priority). In this case, even if we switch backends, then the worst thing that happens is that we switch back to FIFO. |
|
@sbarman agreed that this is the better of the two evils. |
Merged
AJRenold
force-pushed
the
aj-update-priority
branch
from
b51dfbf
to
d73e601
Compare
AJRenold
force-pushed
the
aj-update-priority
branch
from
d73e601
to
5960e73
Compare
sbarman
reviewed
Feb 14, 2017
README.md
Outdated
|
|
||
| zpriority is used to avoid confusion with other celery priority implementations | ||
|
|
||
| Note - tasks created using this backend will have the lowest priority, +inf |
There was a problem hiding this comment.
I would add "tasks created without a zpriority" just to clarify its the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For @sbarman
cc - @yorinasub17
Changes:
zpriorityto avoid confusion with other celery priority implementations