Bridge build fixes #221
Merged
Bridge build fixes #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrimer
requested changes
Oct 19, 2020
DRODLib/BuildUtil.cpp
Outdated
|
|
||
| const UINT baseTile = bConvertFakeElement(tile); | ||
|
|
||
| for (UINT y = py; y <= endY; ++y) { | ||
| bool bAnyBuildSuccessfull = false; |
There was a problem hiding this comment.
bAnyBuildSuccessfull -> bAnyBuildSuccessful
mrimer
reviewed
Oct 19, 2020
EvidentlyCube
force-pushed
the
bridge-build-fixes
branch
from
33268c9
to
40ce32b
Compare
|
PR Updated |
EvidentlyCube
force-pushed
the
bridge-build-fixes
branch
from
40ce32b
to
9024cc9
Compare
|
PR updated again! |
mrimer
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚠ Review this after #220 is merged, since this branch depends on changes from that PR.
Relevant thread 1
Relevant thread 2