Fixes to effect and rendering: #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- O-layer effects dirty room at the end of room drawing to avoid artifacts being left - Temporal projection preview no longer assertion beeps - Steam Effect now draws again - Var Monitor no longer redraws every turn when no changes to variables were detected - Strike orb effect will no longer leave artifacts when triggered by one-use plate or cracked orb - Dialogs which attach to RoomWidget (Current Game Info) will no longer assert beep when getting/losing focus - In the editor characters' swords will not flicker or disapper when sub menus are opened - Removed dead code `CRoomWidget::PutTLayerEffectsOnMLayer()`
mrimer
approved these changes
Nov 5, 2020
mrimer
added a commit
to mrimer/drod
that referenced
this pull request
Nov 5, 2020
mrimer
added a commit
that referenced
this pull request
Nov 5, 2020
RPG: Migrate rendering fixes from #287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O-layer effects dirty room at the end of room drawing to avoid artifacts being left
Temporal projection preview no longer assertion beeps
Steam Effect now draws again
Var Monitor no longer redraws every turn when no changes to variables
were detected
Strike orb effect will no longer leave artifacts when triggered by
one-use plate or cracked orb
Dialogs which attach to RoomWidget (Current Game Info) will no longer
assert beep when getting/losing focus
In the editor characters' swords will not flicker or disapper when
sub menus are opened
Removed dead code
CRoomWidget::PutTLayerEffectsOnMLayer()Relevant thread