Mark monster attached to CFiredCharacterCommand unsafe for deletion #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#156 removes dead monsters that are no longer used by anything. However,
CFiredCharacterCommand
may hold onto a reference to a monster that gets deleted, which can cause a crash. To fix this, monsters that get attached to these commands byCGameScreen::PrepCustomSpeaker
should be marked as unsafe for deletion.Related thread: http://forum.caravelgames.com/viewtopic.php?TopicID=45552