Redraw room when outside state is changed #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrimer
reviewed
Aug 9, 2023
DROD/RoomWidget.cpp
Outdated
| @@ -1889,8 +1889,9 @@ void CRoomWidget::SyncWeather(CCueEvents& CueEvents) | |||
| bWeatherSame &= (this->cFogLayer == (BYTE)roomWeather.wFog); | |||
| bWeatherSame &= (this->wSnow == roomWeather.wSnow); | |||
| bWeatherSame &= (this->rain == roomWeather.rain); | |||
| bool bOutsideSame = (this->bOutside == roomWeather.bOutside); | |||
| bWeatherSame &= (this->bOutside == roomWeather.bOutside); | |||
There was a problem hiding this comment.
Something in this diff doesn't look right to me.
How come the lightning line is being modified, and not the line above it?
There was a problem hiding this comment.
Good catch! I'd deleted the wrong line. It is now fixed.
Hypexion
force-pushed
the
fix-outside-change
branch
from
7bdb302
to
7788f4e
Compare
mrimer
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
_Weathervar is used to change if a room is outside, the room will require a full redraw to account for cloud shadows and sky reflections in water.Thread: https://forum.caravelgames.com/viewtopic.php?TopicID=44130