Fix zero-speed characters animation #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#452 tweaked character drawing to improve support for giving weapons to characters with a non-armed base type. However, it turns out this breaks animation for charaters with zero animation speed.
A more robust check has been added to ensure the swordless frame is only used for a character that 1) has a weapon, either through its base type or setting one using
_MyWeaponand 2) does not have its weapon active, due to it being turned off or sheathed.Thread: https://forum.caravelgames.com/viewtopic.php?TopicID=45989