Skip to content

Commit

Permalink
Add note regarding just-introduced work-around
Browse files Browse the repository at this point in the history
  Remove the work-around is perhaps not as straightforward as upgrading to a more recent node release. Because, clients that haven't would still face the issue. So we need to be a little careful about when to remove this, if we ever do. It's also a fairly small work-around, but it at least deserve a note.
  • Loading branch information
KtorZ committed Jun 29, 2022
1 parent e0c3420 commit 0779651
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions server/src/Ogmios/App/Protocol/TxSubmission.hs
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,16 @@ newExecutionUnitsEvaluator = do
clientStIdle
:: m (LSQ.ClientStIdle block (Point block) (Query block) m ())
clientStIdle = pure $ do
-- NOTE: This little 'dance' of acquiring first is needed because of:
--
-- https://github.com/CardanoSolutions/ogmios/issues/230
--
-- and ideally, can be removed once the upstream fix:
--
-- https://github.com/input-output-hk/ouroboros-network/pull/3844
--
-- has shipped with cardano-node (and it's been long-enough that we
-- can exclude old clients from needing this).
LSQ.SendMsgAcquire Nothing $ LSQ.ClientStAcquiring
{ LSQ.recvMsgAcquired = do
reAcquire <$> await
Expand Down

0 comments on commit 0779651

Please sign in to comment.