Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typos and reinstated running as user in contaier #95

Merged
merged 5 commits into from
May 4, 2023

Conversation

MauriceHendrix
Copy link
Contributor

@MauriceHendrix MauriceHendrix commented May 4, 2023

this should fix those typos and reinstate running as user, mentioned in PR 63

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #95 (832220b) into master (58d8ef6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          30       30           
  Lines        1502     1502           
  Branches      244      244           
=======================================
  Hits         1496     1496           
  Misses          6        6           
Impacted Files Coverage Δ
client/config/production_settings.py 100.00% <100.00%> (ø)
client/core/templatetags/ap_nimbus.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@flawmop
Copy link
Member

flawmop commented May 4, 2023

Can you add the PIVACY_NOTICE rename to these changes and then I'll try them out locally and merge if ok?

@flawmop flawmop merged commit d5cc6e3 into master May 4, 2023
@flawmop flawmop deleted the typos_and_user branch May 4, 2023 15:16
@flawmop
Copy link
Member

flawmop commented May 4, 2023

Rats! Hadn't noticed that the Error-with-timeout branch (for #94) changes hadn't been merged with the typos_and_user branch (for #95), so I'll reapply the Error-with-timeout changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants