Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHIR Standard #25

Merged
merged 14 commits into from
Dec 12, 2022
Merged

FHIR Standard #25

merged 14 commits into from
Dec 12, 2022

Conversation

PSchmiedmayer
Copy link
Member

FHIR Standard

♻️ Current situation & Problem

The CardinalKit modularized architecture is standard-driven but independent of a specific standard. We start instantiated this modularized architecture using the HL7 FHIR standard.
The FHIR standard will be used to communicate FHIR-based resources between different parts of the application.

💡 Proposed solution

The FHIR standard uses FHIR Resources as the base type and ResourceProxy as a communication point with local storage and data storage providers. It provides convenience methods to simplify the creation of FHIR based CardinalKit applications and modules.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #25 (4638262) into main (9720966) will decrease coverage by 2.65%.
The diff coverage is 97.68%.

❗ Current head 4638262 differs from pull request most recent head 8787456. Consider uploading reports for the commit 8787456 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   71.08%   68.44%   -2.64%     
==========================================
  Files          72       39      -33     
  Lines        2928     1077    -1851     
==========================================
- Hits         2081      737    -1344     
+ Misses        847      340     -507     
Impacted Files Coverage Δ
...rdinalKit/CardinalKit/CardinalKitAppDelegate.swift 90.91% <0.00%> (ø)
...rces/CardinalKit/Configuration/Configuration.swift 100.00% <ø> (ø)
...lities/Dependencies/DependenyPropertyWrapper.swift 100.00% <ø> (ø)
...endencies/DynamicDependenciesPropertyWrapper.swift 100.00% <ø> (ø)
...CardinalKit/Standard/StandardPropertyWrapper.swift 100.00% <ø> (ø)
...es/CardinalKit/DataSource/DataSourceRegistry.swift 50.00% <50.00%> (+50.00%) ⬆️
Sources/CardinalKit/CardinalKit/CardinalKit.swift 100.00% <100.00%> (ø)
Sources/CardinalKit/DataSource/DataChange.swift 100.00% <100.00%> (ø)
.../DataSource/DataSourceRegistryAdapterBuilder.swift 100.00% <100.00%> (ø)
...aSource/SingleValueDataSourceRegistryAdapter.swift 100.00% <100.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee28ae...8787456. Read the comment docs.

@PSchmiedmayer PSchmiedmayer marked this pull request as ready for review December 12, 2022 08:27
@PSchmiedmayer PSchmiedmayer merged commit ffb6a41 into main Dec 12, 2022
@PSchmiedmayer PSchmiedmayer deleted the fhirStandard branch December 12, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant