Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick 1 of - do nothing #323

Closed
Zomis opened this issue Jul 11, 2015 · 1 comment
Closed

Pick 1 of - do nothing #323

Zomis opened this issue Jul 11, 2015 · 1 comment
Labels
bug enhancement groovy-effect
Milestone
0.6.1

Comments

@Zomis
Copy link
Member

Zomis commented Jul 11, 2015

At the moment, picking "do nothing" at random fails because of https://github.com/Cardshifter/Cardshifter/blob/master/cardshifter-core/src/main/resources/com/cardshifter/core/modloader/EffectDelegate.groovy#L74 . It should probably be solved by adding a doNothing() no-operation method.
Zomis referenced this issue Jul 11, 2015
Rearrange some cards
cdcd42b
@Zomis Zomis added this to the 0.6.1 milestone Jul 11, 2015
Zomis added a commit that referenced this issue Jul 23, 2015
@Zomis
added doNothing() as a no-op call in EffectDelegate, fixes #323
df895a1
@Zomis
Copy link
Member Author

Zomis commented Jul 23, 2015

It is now possible to use doNothing() as an effect, which will fix this.

@Zomis Zomis closed this as completed Jul 23, 2015
Phrancis pushed a commit that referenced this issue Jul 25, 2015
#323 - doNothing() inside pick atRandom added to mods and docs
3f5350c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement groovy-effect
Projects
None yet
Milestone
0.6.1
Development

No branches or pull requests
1 participant
@Zomis