Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MANA_MAX and MAX_HEALTH #390

Closed
jacwah opened this issue Sep 7, 2015 · 2 comments
Closed

MANA_MAX and MAX_HEALTH #390

jacwah opened this issue Sep 7, 2015 · 2 comments
Labels
enhancement specific-mod
Milestone
0.6.2

Comments

@jacwah
Copy link
Contributor

jacwah commented Sep 7, 2015

The naming of these two resources is inconsistent. #384 is related if we also add HEALTH_ALL.
@Zomis
Copy link
Member

Zomis commented Sep 7, 2015

Thanks for bringing this up, this has been bothering me too!

@Zomis Zomis added this to the 0.6.2 milestone Sep 7, 2015
@jacwah
Copy link
Contributor Author

jacwah commented Sep 10, 2015

I think MAX_MANA and MAX_HEALTH is best for the DSL since it's meant to read as English.

BOTH_HEALTH conveys more meaning than HEALTH_ALL and matches the style above.

jacwah added a commit that referenced this issue Sep 10, 2015
@jacwah
Rename MANA_MAX to MAX_MANA
0641b7e 
See #390.
@jacwah jacwah mentioned this issue Sep 10, 2015
Merged
@jacwah jacwah closed this as completed Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement specific-mod
Projects
None yet
Milestone
0.6.2
Development

No branches or pull requests
2 participants
@Zomis @jacwah