Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cards should be discarded when drawn into a full hand #40

Closed
bazola opened this issue Sep 30, 2014 · 1 comment
Closed

Cards should be discarded when drawn into a full hand #40

bazola opened this issue Sep 30, 2014 · 1 comment
Assignees
@bazola
Labels
bug specific-mod

Comments

@bazola
Copy link
Contributor

bazola commented Sep 30, 2014

If the player has a full hand, when they draw a card that card should be destroyed.
@Zomis
Copy link
Member

Zomis commented Sep 30, 2014

This is already implemented. It doesn't seem like the JavaFX client cares about the EntityRemoveEvent that is being sent though. It needs to check if the entity is in a deck, and if so decrease the counter.

@Zomis Zomis added the bug label Sep 30, 2014
@Zomis Zomis mentioned this issue Sep 30, 2014
Closed
Zomis added a commit that referenced this issue Oct 1, 2014
@Zomis
Added array of ids to ZoneMessage, fixes #41 to let #40 be implemented
dfb994a
@Zomis Zomis added the ready label Oct 1, 2014
@bazola bazola added in progress and removed ready labels Oct 1, 2014
@bazola bazola closed this as completed Oct 1, 2014
@bazola bazola removed the in progress label Oct 1, 2014
@skiwi2 skiwi2 reopened this Oct 1, 2014
@Zomis Zomis closed this as completed Oct 6, 2014
@Zomis Zomis removed the next release label Oct 6, 2014
@Zomis Zomis mentioned this issue Oct 11, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bazola bazola

Labels
bug specific-mod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zomis @skiwi2 @bazola