Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpful and harmless example #128

Merged
merged 19 commits into from
Feb 21, 2023
Merged

Add helpful and harmless example #128

merged 19 commits into from
Feb 21, 2023

Conversation

maxreciprocate
Copy link
Collaborator

@maxreciprocate maxreciprocate commented Dec 8, 2022

@maxreciprocate maxreciprocate marked this pull request as ready for review February 14, 2023 23:09
examples/hh/README.md Show resolved Hide resolved
checkpoint_dir: "checkpoints/ppo_hh"

model:
model_path: "EleutherAI/gpt-j-6B"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's make the default example use a smaller model so more people can run it

Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Max! I left a tiny nit for the README.md.

On another note, I'm hitting an issue when using the GPU-hosting launch command from the README.md (for both ILQL and PPO) where the samples list provided to the ppo_hh reward_fn is empty causing an IndexError. Could you please try this?

Note this only occurs when --num_processes is provided an odd number (quickly checked for 2, 4, and 6 processes fine).

examples/hh/README.md Outdated Show resolved Hide resolved
examples/hh/README.md Outdated Show resolved Hide resolved
@maxreciprocate
Copy link
Collaborator Author

@jon-tow regarding your issue, If you upgrade to accelerate==0.16.0 it will be resolved (I could reproduce it with accelerate==0.15.0)

Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reciprocated I had forgotten about the accelerate==0.15.0 metric bug 😅 This looks great from my end (not sure if @Dahoas has any more feedback).

@Dahoas Dahoas merged commit 93c90cb into main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants