-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt PreTrainedModelWrapper
for Hugging Face models
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto update-pre-commit
…ave-pretrained
…ave-pretrained
…ave-pretrained
Thanks for this PR, I like the reorganization and changes overall! |
cat-state
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! this LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the following changes:
Adopts a modified version of the
PreTrainedModelWrapper
as implemented in thetrl
package, here, to allow for flexible wrapping of Hugging Face (HF) models. This is useful for providing intuitive access to Hugging FacePreTrainedModel
attributes such aspush_to_hub
andsave_pretrained
without having to access the underlying model.Adds ILQL
save_pretrained
support`Introduces the following for HF-based architectures:
AutoModelFor...
to match Hugging Face counterparts.base_model.transformer
andbase_model.lm_head
references and instead extracts the final hidden states from all hidden states in the forward pass. This saves 2x memory on save to disk where previously a model'sstate_dict
stored both.transformer
and.lm_head
as separate states with the underlying transformer.Moves modeling code out of the trainer dir into a separate
models
dir.Renames some
utils.modeling
HF attribute getters fromcausal_lm
todecoder
as many of these utils are helpful in general e.g. for encoder-decoder (seq2seq) models as well (T5Branch
uses the same getter for accessing decoder parts of the transformer).TODOs
save_pretrained
andfrom_pretrained
for ILQL and PPOfrom_config
method to support custom model configs, e.g. as used in some examplestrlx/examples/randomwalks/ilql_randomwalks.py
Line 24 in b2ce1a4
Reports