New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Put everything in checkout folder then filter to "Build" folder #2319
Comments
This would only apply to binary-only frameworks, right? Right now it's downloaded to a temporary directory; we just need to change that to be the correct checkout folder. Yes to Swift! Carthage is Swift-only. |
@mdiep I'm more welcome to any kind of library, especially someone just use this tool as a version management download tool. We can always think about how to build something on top of these checkout stuffs. Right? |
I just mean that it should only apply to Then you'd be free to use whatever you wanted from the checkout folder, yes. |
sorry the reactiveswift code was extremely hard to read.
I can easily find out where it parser the download job, but not sure where is the observer code in debug mode.
Could you point out where?
发自我的 iPhone
… 在 2018年1月20日,01:52,Matt Diephouse ***@***.***> 写道:
I just mean that it should only apply to binary "…" dependencies inside Cartfiles.
Then you'd be free to use whatever you wanted from the checkout folder, yes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@mdiep Any updates on this feature request? |
I don't think anything has been done. PRs welcome. 🙂 |
@mdiep Just to clarify, from development perspective, the idea |
FYI
This statement does not hold true for Carthage. There are plenty of checks to make sure that what is being downloaded & copied to the build folder is a dynamic or static framework. |
The topis is not about the build folder, but before that. From what I understand - this enhancement is about to make the downloaded depencies abailable inside the Checkout folder upon download, and then if they are valid - put them inside the Build folder. So I don’t see how that does not hold true for Carthage. |
If I understand this correctly, the suggested and accepted idea is to change the download folder, form a temporary directory, to a folder inside the Carthage working directory |
Binary dependencies downloads are unchecked but as you correctly said, checks happen before copy. |
Exactly. I'm talking about the binary dependencies downloads only. The copy to the build folder should continue working as expected. As @mdiep said:
|
@blender @mdiep @ikesyo I'm trying to understand how to get access to the downloaded binary dependencies which are missing from the Carthage working directory. Is there a solution or is it rejected or is it still on hold due to something or is it currently in development? |
#2449 is about how This issue is requesting that the archives from It sounds like you're interested in #2449, which is separate from this issue. |
I tought that this issue and #2449 are the same, because my expectations are that upon So I’m really interested in
Any considerations or requirements i should consider before diving into the code? |
No they aren't. 1: Moving contents in a zip file to |
Thanks for the clarification, i got the difference now. |
I've noticed that binary dependencies are not downloaded when using the |
That is #2449. |
…o Carthage/Checkout folder (Carthage#2319 and probably Carthage#2449)
Any chance the related PR (#2532) could be resurrected? I'd find this particularly useful for FirebaseCrashlytics which distributes some binaries (non-framework) for uploading dSYMs to their service. Check out any of the zip files referenced in: https://dl.google.com/dl/firebase/ios/carthage/FirebaseCrashlyticsBinary.json |
As @mdiep mentioned in this ticket:
#2304
The user story background:
Develop want to integration whatever type of library or code
*.a , *.framework, *.h, *.m, *.swfit, even Android *.so library, doesn't matter, right?
The download module just checkout everything into "Checkout" folder, do NOT filter out anything. Carthage has cache feature, right?
Then carthage can try to compile for iOS/tvOS/MacOS/even further Android and put everything in "Build" folder.
What we are trying to archive?
Some times it's just private library, all we need is checkout the zip file and unzip. That's it.
Trying to compile for developers is over-thinking, sometimes it doesn't work that way.
@mdiep I kind of want to help you to develop this feature, If you can point out where to start, I can certainly finish this feature. Do you want me to dev this in swift?
The text was updated successfully, but these errors were encountered: