Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Carthage with Quicklook plugins of type .qlgenerator #2834

Open
relikd opened this issue Jul 29, 2019 · 14 comments
Open

Use Carthage with Quicklook plugins of type .qlgenerator #2834

relikd opened this issue Jul 29, 2019 · 14 comments

Comments

@relikd
Copy link

relikd commented Jul 29, 2019

  • carthage install method: [ ] .pkg, [x] homebrew, [ ] source
  • which carthage: /usr/local/bin/carthage
  • carthage version: 0.33.0

I was wondering if Carthage does support Quicklook generators (.qlgenerator) or only .framework?
I tried to replace all occurences of .qlgenerator with .framework in the shared scheme. No luck. I always get:

Dependency 'X' has no shared framework schemes

Similar to Frameworks, I would like to code-sign and copy the result to a subfolder of the target application. You can test with this repository: QLOPML.
Note: the shared scheme is not pushed in the latest commit since I couldn't get it to work. But I've tried with local pushes and Cartfile: git "file:///.../QLOPML" "master".

@tmspzz
Copy link
Member

tmspzz commented Jul 29, 2019

Cool project! 👍

I'm afraid only .framework with Mach-O dynamic or static library are supported

@relikd
Copy link
Author

relikd commented Jul 30, 2019

Is this something that could be added in the future? If its not too time-consuming …

@tmspzz
Copy link
Member

tmspzz commented Jul 30, 2019

@relikd you can make PR to add support.

@relikd
Copy link
Author

relikd commented Jul 30, 2019

Ok, I'll look into that. Any suggestion where I should start looking?

But I can't build the project. make xcodeproj will result in error: dependency graph is unresolvable. The build directory .build/repositories contains 11 repos but .build/checkout is empty. Also, the fetched repositories are not git work trees but rather the git index, with folders branches, HEAD, and objects, etc.

@kenji21
Copy link
Contributor

kenji21 commented Jul 30, 2019

same issue (trying to update my PR) :

git log -1
commit 68abf2d73791720457f5be1aab4b57df86483f88 (HEAD -> master, origin/master, origin/HEAD)
[...]
$ rm -rf .build/ ; make
swift package --skip-update resolve
Fetching https://github.com/thoughtbot/Curry.git
Fetching https://github.com/Quick/Quick.git
Fetching https://github.com/ReactiveCocoa/ReactiveSwift.git
Fetching https://github.com/Carthage/Commandant.git
Fetching https://github.com/jdhealy/PrettyColors.git
Fetching https://github.com/antitypical/Result.git
Fetching https://github.com/apple/swift-package-manager.git
Fetching https://github.com/Quick/Nimble.git
Fetching https://github.com/mdiep/Tentacle.git
Fetching https://github.com/Carthage/ReactiveTask.git
Fetching https://github.com/apple/swift-llbuild.git
error: dependency graph is unresolvable; found these conflicting requirements:

Dependencies:
    https://github.com/apple/swift-llbuild.git @ swift-DEVELOPMENT-SNAPSHOT-2019-03-04-a
make: *** [installables] Error 1
✘

$ ls .build/repositories/
Commandant-ff702092            Nimble-b9e21ed2                Quick-b5e44b9d                 ReactiveTask-765f743c          Tentacle-817618a1              swift-llbuild-0f2964f9
Curry-b1c82587                 PrettyColors-6e97dd2b          ReactiveSwift-46c9caac         Result-0ec432bc                checkouts-state.json           swift-package-manager-af5448ea
✔︎

$ ls .build/checkouts/

@tmspzz
Copy link
Member

tmspzz commented Jul 30, 2019

run make clean

@relikd
Copy link
Author

relikd commented Jul 30, 2019

Does not work for me. Make fails even for freshly cloned Carthage.

macOS 10.13.6
Xcode 10.0 (10A255)
Apple Swift version 4.2 (swiftlang-1000.11.37.1 clang-1000.11.45.1)
Target: x86_64-apple-darwin17.7.0

@kenji21
Copy link
Contributor

kenji21 commented Jul 30, 2019

$ make clean
swift package clean
swift package reset
✔︎

$ make
swift package --skip-update resolve
Fetching https://github.com/Carthage/Commandant.git
Fetching https://github.com/Quick/Quick.git
Fetching https://github.com/jdhealy/PrettyColors.git
Fetching https://github.com/thoughtbot/Curry.git
Fetching https://github.com/Carthage/ReactiveTask.git
Fetching https://github.com/apple/swift-llbuild.git
Fetching https://github.com/mdiep/Tentacle.git
Fetching https://github.com/ReactiveCocoa/ReactiveSwift.git
Fetching https://github.com/apple/swift-package-manager.git
Fetching https://github.com/Quick/Nimble.git
Fetching https://github.com/antitypical/Result.git
error: dependency graph is unresolvable; found these conflicting requirements:

Dependencies:
    https://github.com/apple/swift-llbuild.git @ swift-DEVELOPMENT-SNAPSHOT-2019-03-04-a
make: *** [installables] Error 1
✘

$ xcodebuild -version
Xcode 10.1
Build version 10B61

same with Xcode 10.3

@tmspzz
Copy link
Member

tmspzz commented Jul 30, 2019

Oh I'm so sorry, I forgot:

make clean && SWIFTPM_BOOTSTRAP=true make

- make clean && SWIFTPM_BOOTSTRAP=true make install

@relikd
Copy link
Author

relikd commented Jul 30, 2019

perfect! should also be added to CONTRIBUTING.md ;-)

@tmspzz
Copy link
Member

tmspzz commented Jul 30, 2019

It's a temporary hack :)

@stale

This comment has been minimized.

@stale stale bot added the stale label Sep 1, 2019
@relikd
Copy link
Author

relikd commented Sep 1, 2019

PR #2843 is ready and waiting

@stale stale bot removed the stale label Sep 1, 2019
@stale
Copy link

stale bot commented Oct 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 1, 2019
@tmspzz tmspzz added enhancement and removed stale labels Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants