Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking out submodules should take advantage of .git/modules #362

Open
jspahrsummers opened this issue Feb 26, 2015 · 4 comments
Open

Checking out submodules should take advantage of .git/modules #362

jspahrsummers opened this issue Feb 26, 2015 · 4 comments

Comments

@jspahrsummers
Copy link
Member

carthage checkout --use-submodules can be really slow for some cases of recursive submodules. It's exacerbated because we don't reuse existing clones that exist within .git/modules/ of the parent repository.

When a repository already exists in .git/modules/, we should probably try reusing it before cloning from Carthage's private cache.

@robrix
Copy link
Contributor

robrix commented Feb 26, 2015

Sounds like a really good idea 👍

@jspahrsummers
Copy link
Member Author

The even-simpler solution might be to just bypass Carthage's cache for the --use-submodules case. That might be acceptable.

@c0diq
Copy link

c0diq commented Apr 29, 2015

My project needs to compile for a lot of different platforms and include a dependency as a submodule currently. I would like Carthage to use the that submodule (and path) when building for iOS or OSX however when I pass --use-submodules Carthage adds a new entry to my submodule to Carthage/Checkouts/XXX. Is or will there be a way for Carthage to use an existing submodule location?

@robrix
Copy link
Contributor

robrix commented Apr 29, 2015

Currently, Carthage expects its dependencies to live in Carthage/Checkouts, and there is not currently any way to tell it not to. I’d suggest using a new issue if that’s valuable to you—this issue is about handling the repo, whereas the checkouts are the working directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants