Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limiting in binary downloads should be a warning, not an error #465

Closed
jspahrsummers opened this issue May 16, 2015 · 4 comments
Closed

Rate limiting in binary downloads should be a warning, not an error #465

jspahrsummers opened this issue May 16, 2015 · 4 comments
Assignees
@ikesyo
Labels
bug checkout

Comments

@jspahrsummers
Copy link
Member

#434 fixed our authentication with the GitHub API, and added proper error reporting for it.

Unfortunately, this has the effect that API rate limiting errors are now fatal, even though binary downloads shouldn't be strictly necessary for building. This can come up in automated workflows, or CI servers, where many requests might be made in a short period of time.

I still want to log rate limiting issues, but I think they should be warnings instead of errors.
@mdiep
Copy link
Member

mdiep commented May 16, 2015

Good call. 👍

nebhale added a commit to nebhale/LoggerLogger that referenced this issue May 26, 2015
@nebhale
Travis build instead of bootstrap
335873c 
Until Carthage/Carthage#465 is fixed, this
changes the build to never download binaries, instead always building
from source.
@jspahrsummers jspahrsummers mentioned this issue Jun 13, 2015
Closed
@jberkel
Copy link

jberkel commented Aug 3, 2015

By contrast, Carthage has been created as a decentralized dependency manager.

By requiring the Github API and causing build failures if it is not accessible? Maybe binary downloads should be opt-in, not opt-out.

@jspahrsummers
Copy link
Member Author

@jberkel You’ve read the issue description, right?

Unfortunately, this has the effect that API rate limiting errors are now fatal, even though binary downloads shouldn't be strictly necessary for building.

We only enjoy snarkiness from those who contribute. Thanks!

@jberkel
Copy link

jberkel commented Aug 3, 2015

Ok, will see if I can come up with a patch to get the snark bit.

@ikesyo ikesyo self-assigned this Aug 12, 2015
@ikesyo ikesyo mentioned this issue Aug 12, 2015
Merged
@wangjiejacques wangjiejacques mentioned this issue Jan 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikesyo ikesyo

Labels
bug checkout
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdiep @jberkel @jspahrsummers @ikesyo