Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdout is hardcoded in CarthageKit #63

Closed
jspahrsummers opened this issue Nov 13, 2014 · 1 comment · Fixed by #103
Closed

stdout is hardcoded in CarthageKit #63

jspahrsummers opened this issue Nov 13, 2014 · 1 comment · Fixed by #103
Assignees
Labels

Comments

@jspahrsummers
Copy link
Member

Everything should be redirectable if we want CarthageKit to be useful in other applications.

@jspahrsummers jspahrsummers added this to the Initial Release milestone Nov 13, 2014
@jspahrsummers
Copy link
Member Author

Ideally, this would not be an “output stream” parameter passed to everything. Instead, we should yield enough information to callers (via returned signals) that they can log whatever they find interesting.

For example, buildScheme() could send an inner signal per scheme built, and subscribers could use the starting/stopping of those inner signals for logging events.

@jspahrsummers jspahrsummers self-assigned this Nov 19, 2014
natanrolnik pushed a commit to natanrolnik/Carthage that referenced this issue Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant