Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --archive option to the build command. #2438

Merged
merged 3 commits into from
May 4, 2018
Merged

Add --archive option to the build command. #2438

merged 3 commits into from
May 4, 2018

Conversation

sunshinejr
Copy link
Contributor

Fixes #1411.

To be honest I just finished the works by @3lvis so credits to him for starting that one 馃槈

@tmspzz
Copy link
Member

tmspzz commented May 2, 2018

So this is an alias for --no-skip-current?

@sunshinejr
Copy link
Contributor Author

@blender Oh, seems like I've missed something while making this PR. In theory, this command would combine both carthage build --no-skip-current & carthage archive. I'll amend the rest of the code, test it again locally and push upstream. Sorry for the confusion.

@sunshinejr
Copy link
Contributor Author

@blender I've updated the PR, should be ready for a review!

@@ -45,6 +59,7 @@ public struct BuildCommand: CommandProtocol {
<*> mode <| Option(key: "verbose", defaultValue: false, usage: "print xcodebuild output inline")
<*> mode <| Option(key: "project-directory", defaultValue: FileManager.default.currentDirectoryPath, usage: "the directory containing the Carthage project")
<*> mode <| Option(key: "log-path", defaultValue: nil, usage: "path to the xcode build output. A temporary file is used by default")
<*> mode <| Option(key: "archive", defaultValue: false, usage: "don't skip building the Carthage project (in addition to its dependencies) and archive")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this description could use a little work.

Maybe:

"archive built frameworks from the current project (implies --no-skip-current)"

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good one! Updating it as we speak.

@mdiep
Copy link
Member

mdiep commented May 4, 2018

This is great! Thanks for the PR!

I think we should tweak the usage description, but otherwise this should be ready to go.

@sunshinejr
Copy link
Contributor Author

Thanks, @mdiep! Updated the description, let me know if there is anything else that can be improved here.

@mdiep
Copy link
Member

mdiep commented May 4, 2018

Thanks @sunshinejr !

@mdiep mdiep merged commit f029456 into Carthage:master May 4, 2018
@sunshinejr sunshinejr deleted the feature/build_archive branch May 4, 2018 17:02
@3lvis
Copy link
Contributor

3lvis commented May 4, 2018

Great job! 馃憦 馃憦 馃憦 馃憦

@sunshinejr
Copy link
Contributor Author

@3lvis @mdiep Thanks guys! Was fun to help, even just a little bit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants