Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --archive option to the build command. #2438

Merged
merged 3 commits into from May 4, 2018
Merged

Add --archive option to the build command. #2438

merged 3 commits into from May 4, 2018

Conversation

@sunshinejr
Copy link
Contributor

@sunshinejr sunshinejr commented May 2, 2018

Fixes #1411.

To be honest I just finished the works by @3lvis so credits to him for starting that one 馃槈

@tmspzz
Copy link
Member

@tmspzz tmspzz commented May 2, 2018

So this is an alias for --no-skip-current?

@sunshinejr
Copy link
Contributor Author

@sunshinejr sunshinejr commented May 2, 2018

@blender Oh, seems like I've missed something while making this PR. In theory, this command would combine both carthage build --no-skip-current & carthage archive. I'll amend the rest of the code, test it again locally and push upstream. Sorry for the confusion.

@sunshinejr
Copy link
Contributor Author

@sunshinejr sunshinejr commented May 2, 2018

@blender I've updated the PR, should be ready for a review!

@@ -45,6 +59,7 @@ public struct BuildCommand: CommandProtocol {
<*> mode <| Option(key: "verbose", defaultValue: false, usage: "print xcodebuild output inline")
<*> mode <| Option(key: "project-directory", defaultValue: FileManager.default.currentDirectoryPath, usage: "the directory containing the Carthage project")
<*> mode <| Option(key: "log-path", defaultValue: nil, usage: "path to the xcode build output. A temporary file is used by default")
<*> mode <| Option(key: "archive", defaultValue: false, usage: "don't skip building the Carthage project (in addition to its dependencies) and archive")

This comment has been minimized.

@mdiep

mdiep May 4, 2018
Member

I think this description could use a little work.

Maybe:

"archive built frameworks from the current project (implies --no-skip-current)"

?

This comment has been minimized.

@sunshinejr

sunshinejr May 4, 2018
Author Contributor

This is a good one! Updating it as we speak.

@mdiep
Copy link
Member

@mdiep mdiep commented May 4, 2018

This is great! Thanks for the PR!

I think we should tweak the usage description, but otherwise this should be ready to go.

@sunshinejr
Copy link
Contributor Author

@sunshinejr sunshinejr commented May 4, 2018

Thanks, @mdiep! Updated the description, let me know if there is anything else that can be improved here.

@mdiep
mdiep approved these changes May 4, 2018
@mdiep
Copy link
Member

@mdiep mdiep commented May 4, 2018

Thanks @sunshinejr !

@mdiep mdiep merged commit f029456 into Carthage:master May 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sunshinejr sunshinejr deleted the sunshinejr:feature/build_archive branch May 4, 2018
@3lvis
Copy link
Contributor

@3lvis 3lvis commented May 4, 2018

Great job! 馃憦 馃憦 馃憦 馃憦

@sunshinejr
Copy link
Contributor Author

@sunshinejr sunshinejr commented May 4, 2018

@3lvis @mdiep Thanks guys! Was fun to help, even just a little bit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants