Add --archive option to the build command. #2438
Conversation
|
So this is an alias for |
|
@blender Oh, seems like I've missed something while making this PR. In theory, this command would combine both |
|
@blender I've updated the PR, should be ready for a review! |
Source/carthage/Build.swift
Outdated
| @@ -45,6 +59,7 @@ public struct BuildCommand: CommandProtocol { | |||
| <*> mode <| Option(key: "verbose", defaultValue: false, usage: "print xcodebuild output inline") | |||
| <*> mode <| Option(key: "project-directory", defaultValue: FileManager.default.currentDirectoryPath, usage: "the directory containing the Carthage project") | |||
| <*> mode <| Option(key: "log-path", defaultValue: nil, usage: "path to the xcode build output. A temporary file is used by default") | |||
| <*> mode <| Option(key: "archive", defaultValue: false, usage: "don't skip building the Carthage project (in addition to its dependencies) and archive") | |||
There was a problem hiding this comment.
I think this description could use a little work.
Maybe:
"archive built frameworks from the current project (implies --no-skip-current)"
?
There was a problem hiding this comment.
This is a good one! Updating it as we speak.
|
This is great! Thanks for the PR! I think we should tweak the usage description, but otherwise this should be ready to go. |
|
Thanks, @mdiep! Updated the description, let me know if there is anything else that can be improved here. |
|
Thanks @sunshinejr ! |
|
Great job! 馃憦 馃憦 馃憦 馃憦 |
Fixes #1411.
To be honest I just finished the works by @3lvis so credits to him for starting that one 馃槈