Fix alt media firebase url parse #3196
Conversation
There was a problem hiding this comment.
Thanks for submitting this! I need to think about this a bit more but overall I like the approach.
One formatting nit: you'll need to use tabs and not spaces for these code changes. It's annoying b/c there's no way to hard-code that setting in our Package.swift, but in Xcode you can set Indent Using: Tabs in the File Inspector, and then reindent these blocks with Editor > Structure > Re-Indent.
|
Also, don't worry about the failing integration test. I've fixed it here, will try to get this commit merged shortly: 978f215 |
…to use the validity check function for all urls
|
@elliottwilliams Finally had some down time to add in the requested changes, let me know what you think! |
|
In the spirit of hacktoberfest.. any chance this could get reviewed again soon? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
No description provided.