Use NSFileManager.moveItemAtURL() as a fallback of rename() system call when EXDEV error occurred #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manpage of rename() says: > Both old and new must be of the same type (that is, both must be either directories or non-directories) nondirectories) directories) and must reside on the same file system. On the other hand, the documentation of NSFileManager.moveItemAtURL() says: > If the source and destination of the move operation are not on the same volume, this method copies the item first and then removes it from its current location.
|
Originally /cc @jspahrsummers |
|
Hi — just wanted to check in: is |
|
rename() is atomic, and also replaces the destination if need be. NSFileManager offers neither of these guarantees, unfortunately. |
|
Checking for EXDEV is a good idea. 👍 |
…ll when EXDEV error occurred
ikesyo
changed the title
|
Thank you for your inputs! 🙏 I've updated the PR. |
|
Looks good to me! |
mdiep
added a commit
that referenced
this pull request
Sep 9, 2015
Use NSFileManager.moveItemAtURL() as a fallback of rename() system call when EXDEV error occurred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #706 and #711.
The manpage of
rename()says:On the other hand, the documentation of
NSFileManager.moveItemAtURL()says: