Skip building static frameworks by checking Mach-O type #894
Conversation
ikesyo
changed the title
ikesyo
changed the title
| .flatMap(.Concat) { settings -> SignalProducer<ProductType, CarthageError> in | ||
| let productType = SignalProducer(result: settings.productType) | ||
| .flatMap(.Concat) { settings -> SignalProducer<(ProductType, MachOType), CarthageError> in | ||
| let typePair = SignalProducer(result: settings.productType &&& settings.machOType) |
There was a problem hiding this comment.
Ooooh nice, I forgot this operator.
|
Great idea! |
| @@ -468,6 +468,30 @@ public enum ProductType: String { | |||
| } | |||
| } | |||
|
|
|||
| /// Describes the type of Mach-O files. | |||
| /// See https://developer.apple.com/library/mac/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW73. | |||
There was a problem hiding this comment.
$5 says this link won't work in a year. 😄
There was a problem hiding this comment.
Sorry, you should leave it in. I was just joking because it's frustrating how Apple breaks these links all the time.
There was a problem hiding this comment.
Oh, forgive my misunderstanding. 😝
|
I really like this idea! Thanks for working on it. 💖 |
|
@ikesyo I think I'll create a new release after this is merged so we can get a working build with homebrew. Does that sound good to you? |
|
@mdiep Sounds good! 👍 |
|
How do you feel the changes in d8b22ec? |
| } | ||
|
|
||
| /// Describes the type of frameworks. | ||
| private enum FrameworkType { |
There was a problem hiding this comment.
I'm not convinced this should be private or public.
|
This looks good. 👍 |
Skip building static frameworks by checking Mach-O type
|
Thank you for the feedbacks. 💖 |
Addresses #734 and #889.