-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old API #278
Merged
Merged
Remove old API #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/cartodb/cartodb_windshaft.js package.json
Conflicts: package.json
Conflicts: lib/cartodb/cartodb_windshaft.js lib/cartodb/server_options.js package.json
A lot of tests from acceptance/server.js will fail
Moves all tests to run on new URLs Deprecated base_url_legacy in config, it will keep working tho
- uses nock to mock request - a bit hacky because tests keep environment inconsistent * for intance I had to mock cartocdn to not fail in other suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implies a MAJOR RELEASE with BREAKING CHANGES
/:table/infowindow
,/:table/map_metadata
and/:table/flush_cache
endpoints/tiles/template
and/tiles/layergroup
/api/v1/map/named
and/api/v1/map
This closes #257 #52 #101 #102