Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dissagregate AU and CA population columns #543

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Dissagregate AU and CA population columns #543

merged 1 commit into from
Aug 6, 2018

Conversation

ethervoid
Copy link
Contributor

@ethervoid ethervoid commented Aug 6, 2018 •
edited

Related #542

houndci-bot
houndci-bot reviewed Aug 6, 2018
View reviewed changes
tasks/geographica/au/csv.py
@@ -91,6 +91,7 @@ def _generate_csv_file(self, headers, measurements):
try:
self.output().makedirs()
with(open(self.output().path, 'w+')) as csvfile:
headers[0]='geoid'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace around operator

houndci-bot
houndci-bot reviewed Aug 6, 2018
View reviewed changes
tasks/geographica/au/csv.py
@@ -91,6 +91,7 @@ def _generate_csv_file(self, headers, measurements):
try:
self.output().makedirs()
with(open(self.output().path, 'w+')) as csvfile:
headers[0]='geoid'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace around operator

antoniocarlon
antoniocarlon approved these changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@antoniocarlon antoniocarlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question: I see denom_ids for the measurements, are we returning ratios or just the plain measurements?

@ethervoid
Copy link
Contributor Author

Plain measurements

@ethervoid ethervoid merged commit 265c437 into master Aug 6, 2018
@ethervoid ethervoid deleted the au_ca_csv_disaggregated_data branch August 6, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@antoniocarlon antoniocarlon antoniocarlon approved these changes

Assignees

@antoniocarlon antoniocarlon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ethervoid @antoniocarlon @houndci-bot