Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

396 - fix message logs #399

Merged
merged 5 commits into from
Mar 4, 2020
Merged

396 - fix message logs #399

merged 5 commits into from
Mar 4, 2020

Conversation

juanrmn
Copy link
Member

@juanrmn juanrmn commented Feb 18, 2020 •
edited

Issue #396

@juanrmn juanrmn changed the title fix message logs 396 - fix message logs Feb 18, 2020
@juanrmn juanrmn marked this pull request as ready for review February 18, 2020 09:23
@juanrmn
Copy link
Member Author

juanrmn commented Feb 18, 2020

A check test didn't pass, but it doesn't seem to be related to the changes (AFAIK). If it's related to this, please let me know how can I fix it.

@juanrmn juanrmn mentioned this pull request Feb 18, 2020
Closed
@dgaubert
Copy link
Contributor

Fixed by re-running the job via Travis UI.

jgoizueta
jgoizueta approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@jgoizueta jgoizueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'd leave this as is (with all the messages) and test it/deploy it. We'll reconsider later if we should remove some messages (Probably the only interesting one is the Categories data...

@dgaubert
Copy link
Contributor

dgaubert commented Mar 3, 2020

Seems like it isn't merged nor deployed, is it @juanrmn @jgoizueta ??

Shall I continue this PR?

@dgaubert dgaubert merged commit 9d69235 into master Mar 4, 2020
@dgaubert dgaubert deleted the 396/fix-logs-messages branch March 4, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgoizueta jgoizueta jgoizueta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juanrmn @dgaubert @jgoizueta