Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing dom reference in TimeSeriesChart #842

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

jantolg
Copy link
Contributor

@jantolg jantolg commented Feb 19, 2024

Description

  • fix: wrong usage dom element without reference

Copy link

github-actions bot commented Feb 19, 2024

Pull Request Test Coverage Report for Build 8140172198

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.559%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/TimeSeriesWidgetUI/components/TimeSeriesChart.js 0 1 0.0%
Totals Coverage Status
Change from base Build 7956818395: 0.0%
Covered Lines: 2626
Relevant Lines: 3489

💛 - Coveralls

Copy link

github-actions bot commented Feb 19, 2024

Visit the preview URL for this PR (updated for commit f32a8f8):

https://cartodb-fb-storybook-react-dev--pr842-fix-timeseriesch-0dg6dk34.web.app

(expires Mon, 11 Mar 2024 12:35:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@padawannn padawannn merged commit 732cc12 into master Mar 5, 2024
2 checks passed
@padawannn padawannn deleted the fix/timeserieschart-missing-dom-references branch March 5, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants