Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Authorization header to Cartoauthorization for Snowflake Native Apps #849

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

moicalcob
Copy link
Contributor

Description

Shortcut: (link?)

Please include a summary of the change. If required, also include relevant info about motivation and context... And if PR includes UI elements (or if it helps for understanding it), please add extra files: snapshots, videos...

If this PR requires a companion in carto-react-template, please also link them both.

Type of change

(choose one and remove the others)

  • Fix
  • Feature
  • Refactor
  • Tests
  • Documentation

Acceptance

Please describe how to validate the feature or fix

  1. go to X
  2. test Y
  3. assert Z

If feature deals with theme / UI or internal elements used also in CARTO 3, please also add a note on how to do acceptance on that part.

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@moicalcob moicalcob changed the title Mcalzado v2.3.11 Change Authorization header to Cartoauthorization for Snowflake Native Apps Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Pull Request Test Coverage Report for Build 8170717668

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.561%

Totals Coverage Status
Change from base Build 8170229593: 0.0%
Covered Lines: 2630
Relevant Lines: 3493

💛 - Coveralls

lerna.json Outdated
@@ -4,5 +4,5 @@
],
"npmClient": "yarn",
"useWorkspaces": true,
"version": "2.3.13"
"version": "2.3.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version is 2.3.13 we cannot downgrade to 2.3.11

@@ -1,6 +1,6 @@
{
"name": "@carto/react-auth",
"version": "2.3.13",
"version": "2.3.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version is 2.3.13 we cannot downgrade to 2.3.11 and the same for the following packages

Copy link

github-actions bot commented Mar 6, 2024

Visit the preview URL for this PR (updated for commit 6c76774):

https://cartodb-fb-storybook-react-dev--pr849-mcalzado-v2-3-11-w1x4j3uz.web.app

(expires Wed, 13 Mar 2024 10:44:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants