fix: keep always two digits at PieWidgetUI default percentFormatter #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8173764685Details
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit ade9afa): https://cartodb-fb-storybook-react-dev--pr850-fix-keep-two-dec-zya52p6w.web.app (expires Wed, 13 Mar 2024 14:37:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
vmilan
reviewed
Mar 6, 2024
| @@ -71,7 +71,11 @@ function PieWidgetUI({ | |||
| const _percentFormatter = useMemo( | |||
| () => | |||
| percentFormatter || | |||
| ((v) => `${intl.formatNumber(v, { maximumFractionDigits: 2 })}%`), | |||
| ((v) => | |||
There was a problem hiding this comment.
As this has caused problems with e2e, please double-check the case when total === 0, it should returns 0,00%
It was also modified in your last PR -> https://github.com/CartoDB/carto-react/pull/844/files#diff-aef7c79c208e732a247556c69887e48f3f8b2076d3bf28aeeb9abde1419806adL98-L99
padawannn
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related by: #844
Keep two decimals always in default percent formatters in PieWidgetUI
Type of change
Acceptance
Please describe how to validate the feature or fix