Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable histogram y axis #860

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

juandjara
Copy link
Contributor

@juandjara juandjara commented Apr 3, 2024

Description

Shortcut: https://app.shortcut.com/cartoteam/story/400198/ui-pdf-report-in-the-pdf-preview-mode-the-histogram-chart-widget-is-interactive-and-shouldn-t-be

This is a PR with a feature required in the design QA phase of the PDF Report in Builder initiative

Type of change

  • Feature

Acceptance

Please describe how to validate the feature or fix

  1. Open C4R Storybook
  2. Go to story for HistogramWidgetUI
  3. Select yAxisType as full
  4. it should look like this

Captura de pantalla 2024-04-03 a las 17 12 30

If feature deals with theme / UI or internal elements used also in CARTO 3, please also add a note on how to do acceptance on that part.

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

Copy link

github-actions bot commented Apr 3, 2024

Visit the preview URL for this PR (updated for commit dbe7924):

https://cartodb-fb-storybook-react-dev--pr860-feature-configur-0eeznkrk.web.app

(expires Mon, 15 Apr 2024 08:51:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@coveralls
Copy link
Collaborator

coveralls commented Apr 3, 2024

Pull Request Test Coverage Report for Build 8597188881

Details

  • 5 of 11 (45.45%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 68.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/HistogramWidgetUI/HistogramWidgetUI.js 5 11 45.45%
Totals Coverage Status
Change from base Build 8537168176: -0.002%
Covered Lines: 2682
Relevant Lines: 3575

💛 - Coveralls

@padawannn padawannn merged commit e242971 into master Apr 10, 2024
2 checks passed
@padawannn padawannn deleted the feature/configurable-histogram-y-axis branch April 10, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants