Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableWidget: support for object values #867

Merged
merged 2 commits into from Apr 22, 2024

Conversation

padawannn
Copy link
Contributor

Description

Avoid TableWidetUI crash if it receives an object value

  • Fix

@padawannn padawannn requested a review from a team April 22, 2024 09:24
Copy link

github-actions bot commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8781720645

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 71.231%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/TableWidgetUI/TableWidgetUI.js 1 2 50.0%
Totals Coverage Status
Change from base Build 8780464752: -0.02%
Covered Lines: 2805
Relevant Lines: 3627

💛 - Coveralls

Copy link

github-actions bot commented Apr 22, 2024

Visit the preview URL for this PR (updated for commit 7fa32a2):

https://cartodb-fb-storybook-react-dev--pr867-padawannn-suppor-fbsr6c88.web.app

(expires Mon, 29 Apr 2024 09:32:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@padawannn padawannn merged commit 581c06c into master Apr 22, 2024
2 checks passed
@padawannn padawannn deleted the padawannn/support_object_table_widget branch April 22, 2024 09:35
padawannn added a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants