Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add century and millenium to date aggregation #2162

Merged
merged 2 commits into from
Jul 4, 2018

Conversation

sverhoeven
Copy link
Contributor

@ivanmalagon
Copy link
Contributor

Thanks @sverhoeven

As this apply as an obvious fix because it doesn't add any new functionality, just extends what was missing you don't need to sign any CLA https://carto.com/contributions/

Anyway, we first need to check how this behaves with Builder. If it doesn't affect Builder, we'll merge it.

Thanks again.

@rubenmoya rubenmoya self-assigned this Jul 4, 2018
Copy link
Contributor

@rubenmoya rubenmoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Builder and it behaves as expected. LGTM!

@rubenmoya rubenmoya merged commit e2780e2 into CartoDB:master Jul 4, 2018
@rubenmoya rubenmoya removed their assignment Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants